D8175: Move URL handling from the processing to the rendering plugin
Volker Krause
noreply at phabricator.kde.org
Mon Oct 9 20:17:23 BST 2017
vkrause added inline comments.
INLINE COMMENTS
> knauss wrote in bodypartformatterfactory.cpp:156
> no the idea is that in mimetreeparser there is no plugin loader, this should be in messageviewer. Because the plugins may be specific for a specific messageviewer, that's why the messageviewer needs to control this. For Kube as example the plugins would need different plugins, becuase tithey support a different set. That was the base idea of this BaseFactory to give full control ovr the plugins to the messageviewer.
The solution for that is adding a way to change the plugin search path (or add some other way of filtering the plugins by additional metadata), not to duplicate the entire plugin loading code. This becomes even more relevant once we add on-demand plugin loading, when this wont be a single function anymore.
Your approach would also mean we would never be able to use MTP stand-alone without MV, but I think e.g. our composer would actually only need MTP, not the full MV.
REPOSITORY
R94 PIM: Message Library
REVISION DETAIL
https://phabricator.kde.org/D8175
To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171009/b8e0ad73/attachment.html>
More information about the kde-pim
mailing list