D8551: Probe attachment mimetypes ourselves when there's doubt

Volker Krause noreply at phabricator.kde.org
Tue Oct 31 11:36:46 GMT 2017


vkrause added inline comments.

INLINE COMMENTS

> knauss wrote in objecttreeparser.cpp:270
> maybe you want use NodeHelper::magicSetType / maybe without modifiing the contentType... This method is called later on from AttachmentMessagePartRenderer::render ...

Yep, that works much better, with a lot less code changes required, plugins just work out of the box :)

There's just one little issue in KMime breaking some stuff as a result of this change, as changing the content type will currently lose all other parameters in the Content-Type header.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D8551

To: vkrause
Cc: knauss, #kde_pim, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171031/df31fbba/attachment.html>


More information about the kde-pim mailing list