D8465: ItemSync: speed up by not using takeFirst().

David Faure noreply at phabricator.kde.org
Wed Oct 25 11:15:42 BST 2017


dfaure created this revision.
dfaure added a reviewer: dvratil.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  perf+hotspot shows that this is a horrible algorithm:
  http://www.davidfaure.fr/kde/perf_hotspot_itemsync.png
  
  I ported the code to the std::move (the algorithm), but I'm not
  sure how to test it, the itemsynctest unittest fails for me even
  before this change.

TEST PLAN
  none yet. It compiles, though :-)

REPOSITORY
  R165 Akonadi

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D8465

AFFECTED FILES
  src/core/itemsync.cpp

To: dfaure, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171025/64e4644b/attachment.html>


More information about the kde-pim mailing list