D8247: Port UUEncode parsing to QRegularExpression

Laurent Montel noreply at phabricator.kde.org
Wed Oct 11 15:24:53 BST 2017


mlaurent added inline comments.

INLINE COMMENTS

> kmime_parsers.cpp:232
>                  // message may be split up => parse subject
> -                QRegExp rx(QStringLiteral("[0-9]+/[0-9]+"));
> -                pos = rx.indexIn(QLatin1String(m_subject), 0);
> -                len = rx.matchedLength();
> +                const QRegularExpression rx(QStringLiteral("[0-9]+/[0-9]+"));
> +                const auto match = rx.match(QLatin1String(m_subject));

PErhaps this line can be move on top as other QRegularExpression no ?
not necessary to recreate it all the time.

REPOSITORY
  R180 PIM: KMime

REVISION DETAIL
  https://phabricator.kde.org/D8247

To: dvratil, vkrause
Cc: mlaurent, #kde_pim, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171011/8047d40f/attachment.html>


More information about the kde-pim mailing list