D8091: Added Hide Read Feed option

[Daniel Vrátil]

dvratil added a comment.


  There are still a few one-line `if` statements with missing brackets in `Akregator::FilterUnreadProxyModel`, please fix those as well.
  
  > I updated the style fixes. I originally wrote this patch back in 2011 back when the code didn't have a consistent style, so I missed some stuff when I updated it for submission, sorry about that.
  
  No worries, that's why we have code review :-)

INLINE COMMENTS

> subscriptionlistmodel.cpp:126
> +    //if we're deselecting an empty feed/folder, we need to hide it
> +    if (desel.size() > 0) {
> +        if (m_selectedHierarchy.contains(desel.at(0)))

`!desel.isEmpty()`  (`QList` does not cache size)

> subscriptionlistmodel.h:75
> +    //reimpl
> +    bool filterAcceptsRow(int source_row, const QModelIndex &source_parent) const;
> +

Missing `override`

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D8091

To: sagara, dvratil
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171001/cd84a1de/attachment.html>