D8802: Simplify FavoriteCollectionsModel: inherit KSelectionProxyModel
David Faure
noreply at phabricator.kde.org
Mon Nov 13 21:18:29 GMT 2017
dfaure created this revision.
dfaure added reviewers: dvratil, cmollekopf.
Restricted Application added a project: KDE PIM.
REVISION SUMMARY
instead of inheriting from Akonadi::SelectionProxyModel and disabling
the very little that Akonadi::SelectionProxyModel does compared to
its base class, KSelectionProxyModel.
And add a comment about why QSortFilterProxyModel wouldn't do,
replacing the comment that we should inherit from that instead.
TEST PLAN
Favorites work like before. The code is cleaner :)
REPOSITORY
R165 Akonadi
BRANCH
kselectionproxymodel
REVISION DETAIL
https://phabricator.kde.org/D8802
AFFECTED FILES
src/core/models/favoritecollectionsmodel.cpp
src/core/models/favoritecollectionsmodel.h
To: dfaure, dvratil, cmollekopf
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171113/c12a7c58/attachment.html>
More information about the kde-pim
mailing list