D8995: Fix obvious porting error, allDay was ignored.
David Faure
noreply at phabricator.kde.org
Sat Nov 25 12:45:17 GMT 2017
dfaure created this revision.
dfaure added a reviewer: dvratil.
Restricted Application added a project: KDE PIM.
REVISION SUMMARY
Commit https://phabricator.kde.org/R172:df84459e75cec10d7460af38cc3358e9eace10d0 contained:
- todo->setAllDay(kdt.isDateOnly());
+ todo->setAllDay(false);
Added a unittest for todos with date-only start/end/due dates,
just like zanshin does. This test file would have caught this porting
bug.
Tested with libical-1.0.1 only.
TEST PLAN
Unittest + zanshin
REPOSITORY
R172 KCalendar Core
BRANCH
fix_porting_error
REVISION DETAIL
https://phabricator.kde.org/D8995
AFFECTED FILES
autotests/data/Compat-libical3/Todos.ics
autotests/data/Compat-libical3/Todos.ics.ical.ref
autotests/data/Compat/Todos.ics
autotests/data/Compat/Todos.ics.ical.ref
src/icalformat_p.cpp
To: dfaure, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171125/c3b2c53b/attachment.html>
More information about the kde-pim
mailing list