Review Request 127845: Fix message

Sandro Knauß sknauss at kde.org
Mon Nov 13 22:46:28 GMT 2017



> On May 5, 2016, 9:27 p.m., Allen Winter wrote:
> > src/acl/aclmodifyjob.cpp
> > Line 180 (original), 180 (patched)
> > <https://git.reviewboard.kde.org/r/127845/diff/1/?file=464187#file464187line180>
> >
> >     how about:
> >     
> >     "Do you really want to apply the folder's permissions to these subfolders?"
> 
> Frederik Schwarzer wrote:
>     Hmm, yes, if folderNames refers to the subfolders and the "folder" in question is singular, your suggestion is correct. Can anyone confirm this?

I can confirm this: It is really about setting the permissions of one folder to the subfolders - and folderNames are "only" the subfolders.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127845/#review95216
-----------------------------------------------------------


On May 5, 2016, 8:45 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127845/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 8:45 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries and Laurent Montel.
> 
> 
> Repository: pimcommon
> 
> 
> Description
> -------
> 
> Since folderNames is plural, we need proper plural here.
> 
> 
> Diffs
> -----
> 
>   src/acl/aclmodifyjob.cpp 7064207 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/127845/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171113/f2b78aa9/attachment.html>


More information about the kde-pim mailing list