D8679: KMail redirect dialogue: Improve layout
Jonathan Marten
noreply at phabricator.kde.org
Mon Nov 6 12:12:33 GMT 2017
marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.
REVISION SUMMARY
The original layout of the dialogue:
F5478642: kmail-redirectdialogue-BEFORE.png <https://phabricator.kde.org/F5478642>
is missing the default layout spacing between the three address labels and their fields, and around the two combo boxes.
These changes restore that spacing;
F5478646: kmail-redirectdialogue-AFTER.png <https://phabricator.kde.org/F5478646>
The implementation is slightly complicated because using the default form layout spacing would result in double spacing around the address fields, caused by the push buttons. To avoid this, the form layout vertical spacing is set to zero and explicit spacing is added around the combo boxes.
The focus policy of the RedirectWidget is set so that buddy accelerators work.
TEST PLAN
Built mailcommon with this change, observed correct appearance and operation of the dialogue.
REPOSITORY
R92 PIM: Common Mail Support
REVISION DETAIL
https://phabricator.kde.org/D8679
AFFECTED FILES
src/widgets/redirectdialog.cpp
src/widgets/redirectwidget.cpp
To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171106/886434d9/attachment.html>
More information about the kde-pim
mailing list