D8693: FavoriteCollectionsModel: don't use parent().child().

David Faure noreply at phabricator.kde.org
Tue Nov 7 13:19:05 GMT 2017


dfaure created this revision.
dfaure added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  parent() can be an invalid index, and sibling() is faster.

TEST PLAN
  Favorites still work, this didn't create an actual bug because
  the underlying model seems to emit layoutChanged anyway, but I found this
  when starting to play with changing the model stack underneath.

REPOSITORY
  R165 Akonadi

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D8693

AFFECTED FILES
  src/core/models/favoritecollectionsmodel.cpp

To: dfaure, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171107/9b1b4715/attachment.html>


More information about the kde-pim mailing list