D5711: previous fix in monitoredItemRemoved() was incorrect

Daniel Vrátil noreply at phabricator.kde.org
Sat May 6 00:14:37 BST 2017


dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Phab seems to be unable to display proper context for any of your patches, how are you generating/publishing them?

INLINE COMMENTS

> entitytreemodel_p.cpp:4


This won't work - just exclude the Akonadi::Collection parameter here and Qt will correctly use the default parameter value for the collection.

> entitytreemodel_p.cpp:23


Not sure if it's Phabricator, but the patch looks incomplete or broken - there seems to be missing chunk here.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D5711

To: mkoller, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170505/a8c303b0/attachment.html>


More information about the kde-pim mailing list