D5737: Use base64 encoding for all non-text attachments

[Daniel Vrátil]

dvratil created this revision.
dvratil added a project: KDE PIM.
Restricted Application added a subscriber: KDE PIM.

REVISION SUMMARY
  Use base64 encoding for all non-text attachments, only use KMime::encodingForData()
  for text/* and message/* attachments.
  
  KMime::encodingForData() uses character occurrence frequency to choose optimal encoding,
  but in case of binary documents (like PDF) this can get completely off and choose the wrong
  encoding and CRLF/LF conversion then corrupts the binary data, making the attachment unreadable.
  
  See https://bugs.kde.org/show_bug.cgi?id=95733 for details

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D5737

AFFECTED FILES
  messagecore/src/attachment/attachmentpart.cpp

To: dvratil, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170507/6d2707b2/attachment.html>