D5711: previous fix in monitoredItemRemoved() was incorrect

Daniel Vrátil noreply at phabricator.kde.org
Fri May 5 09:20:09 BST 2017


dvratil added a comment.


  The difference comes likely from the Monitor. Better solution (which allows us keeping the if () check) is to pass the parent collection as a second argument to monitoredItemRemoved() (with Collection() as default value) - when called from monitoredItemMoved, you pass the sourceCollection, when called from elsewhere, you won't pass anything and then you just check if the collection is valid and use it in the if(), or fallback to item.parentCollection().

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D5711

To: mkoller, dvratil
Cc: #kde_pim, dvasin, ach, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170505/0c4d8775/attachment.html>


More information about the kde-pim mailing list