Review Request 130051: Allow the user to silence some sync warnings

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130051/#review102952
-----------------------------------------------------------



Personally this at least solves my issue. Thanks for this.
Still I wonder why this is only done in the POP resource and not (or different) in others.
This is inconsistent.

Also I think it should not be up to the resource to decide HOW an error or warning is displayed.
AFAIK therefore the Akonadi::AgentBase signals like 
void 	warning (const QString &message)
void 	error (const QString &message)
are available.

- Martin Koller


On March 26, 2017, 11:20 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130051/
> -----------------------------------------------------------
> 
> (Updated March 26, 2017, 11:20 p.m.)
> 
> 
> Review request for KDEPIM and Martin Koller.
> 
> 
> Bugs: 377553
>     http://bugs.kde.org/show_bug.cgi?id=377553
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> One user has complained that an error dialog pops up when the server can't be contacted (e.g. behind a vpn or something)
> 
> First i thought of not showing the error for ERR_UNKNOWN_HOST errors, but then i thought it would make sense to be notified at least once if you wrote the address wrong, so i went for the "don't show me again" route.
> 
> 
> Diffs
> -----
> 
>   resources/pop3/pop3resource.h 544b25be4 
>   resources/pop3/pop3resource.cpp ef4e02c3b 
> 
> Diff: https://git.reviewboard.kde.org/r/130051/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170327/ad429d8c/attachment.html>