D6368: [Views] Flatten event items

Olivier Churlaud noreply at phabricator.kde.org
Sun Jun 25 16:19:18 BST 2017


ochurlaud added a comment.


  In https://phabricator.kde.org/D6368#119246, @winterz wrote:
  
  > I applied the patch locally and tested it.  I think I like the new look better but I'm not sure. 
  >  Please post screenshots so we can make it easier for other folks to compare the before and after.
  >
  > ... also you have some unused argument warnings in drawEventRect().  please fix those warnings.
  
  
  Shall I fix the warning by using Q_UNUSED(..) or by changing the signature of the function? I didn't use the parameters there, but they might be useful one day...

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D6368

To: ochurlaud, dvratil, mlaurent
Cc: winterz, #kde_pim, dvasin, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170625/97261c14/attachment.html>


More information about the kde-pim mailing list