D6207: Introduce the password provider class

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  You missed to increase libksieve version.

INLINE COMMENTS

> utilmethodtest.cpp:37
> +
> +    QString password(const QString &/*identifier*/) override
> +    {

it's in still in 17.04 it's Q_DECL_OVERRIDE
if you put in master it's override.

> vacation.h:66
>      // IO:
> +    SieveImapPasswordProvider* m_passwordProvider;
>      KManageSieve::SieveJob *mSieveJob;

mPasswordProvider.

> custommanagesievewidget.h:37
> +private:
> +    SieveImapPasswordProvider* m_passwordProvider;
>  };

mPasswordProvider

REPOSITORY
  R91 PIM: Sieve Handling Library

REVISION DETAIL
  https://phabricator.kde.org/D6207

To: aacid, dvratil, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170613/51321636/attachment.html>