D6859: Cleanup unused dependencies

Andreas Sturmlechner noreply at phabricator.kde.org
Mon Jul 24 19:22:09 BST 2017


asturmlechner added a comment.


  In https://phabricator.kde.org/D6859#128081, @mlaurent wrote:
  
  > Please change as master not 17.08 as you remove some dep/lib
  
  
  Are you absolutely sure? It just removes deps that aren't used at all, and with the remaining time to RC we are safe to catch any unintended fallout imo.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:197
> it seems wierd as when I grep QIcon:: I see a lot of items here.
> For me we need to keep it.

QIcon is part of QtGui, but indeed KIconLoader is used here so I'm adding it back. It probably just worked because being implicitly pulled in.

REPOSITORY
  R95 PIM: Common Support

REVISION DETAIL
  https://phabricator.kde.org/D6859

To: asturmlechner, #kde_pim, mlaurent
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170724/a5d4de2c/attachment.html>


More information about the kde-pim mailing list