D6516: Fix selecting the color from a set of filters
Justus Winter
noreply at phabricator.kde.org
Thu Jul 6 14:59:26 BST 2017
justusw marked 3 inline comments as done.
justusw added a comment.
In https://phabricator.kde.org/D6516#122148, @aheinecke wrote:
> Looks good in general to me apart from my inline comments. The filter stuff I will test now because I can't see from the code if it works as intended.
Cool.
> Regarding style: Please replace all tabs with 4 spaces. And we don't have a space between "!" and the statement.
Right.
> The Style is documented under:
> https://techbase.kde.org/Policies/Kdelibs_Coding_Style
>
> It even has an Emacs Mode for KDE ;-P
The kde-emacs stuff doesn't work for me, also, it changes the indentation mode unconditionally, which I despise for obvious reasons. Usually, I have a 'do-the-right-thing' mode, I'm not sure why it failed for the formatting.cpp, maybe because of the local variables, which I took the liberty to update now.
REPOSITORY
R90 PIM: Kleo Library
REVISION DETAIL
https://phabricator.kde.org/D6516
To: justusw, aheinecke
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170706/80ae8815/attachment.html>
More information about the kde-pim
mailing list