D6931: Use ecm's FindInotify.cmake

Daniel Vrátil noreply at phabricator.kde.org
Thu Jul 27 11:09:17 BST 2017


dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:27
> +                       PURPOSE "Filesystem alteration notifications using inotify")
> +macro_bool_to_01(SYS_INOTIFY_H_FOUND Inotify_FOUND)
>  configure_file(config-messageviewer.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-messageviewer.h)

I think this is wrong. The `macro_bool_to_01` evaluates the first argument and then sets the remaining arguments to 0 or 1 based on it, so it should be:

  macro_bool_to_01(Inotify_FOUND HAVE_SYS_INOTIFY_H)

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D6931

To: tcberner, #freebsd, dvratil, mlaurent
Cc: winterz, #kde_pim, dvasin, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170727/2cdec86c/attachment.html>


More information about the kde-pim mailing list