D6517: Add helper for dealing with compliance modes

Justus Winter noreply at phabricator.kde.org
Thu Jul 6 11:22:42 BST 2017


justusw added inline comments.

INLINE COMMENTS

> gnupg-helper.cpp:280
> +
> +bool Kleo::gpgComplianceP(const char *mode)
> +{

So this duplicates functionality from libkleo, which is bad, but a) I did not know where to put it exactly in libkleo (see the other diff), and b) frankly, I like my predicate better because it is easier to use (avoids the QStringLiteral("de-vs") in the expression.

> gnupg-helper.cpp:289
> +
> +enum GpgME::UserID::Validity Kleo::keyValidity(const GpgME::Key &key)
> +{

Likewise.

REPOSITORY
  R168 Kleopatra

REVISION DETAIL
  https://phabricator.kde.org/D6517

To: justusw, aheinecke
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170706/75bb2a9f/attachment.html>


More information about the kde-pim mailing list