D6879: Replace SMTP KIO Slave with KSmtp library

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  Hi,
  make sure that we can send email with several smtp server :)
  
  I will be off tomorrow until friday, so I hope that I will able to accept your patch :)
  
  Regards.

INLINE COMMENTS

> fakeserver.cpp:27
> +FakeServer::FakeServer(QObject *parent) :
> +    QThread(parent)
> +{

initialize m_tcpServer to nullptr

> fakeserver.cpp:165
> +
> +    foreach (const QList<QByteArray> &scenario, m_scenarios) {
> +        if (!scenario.isEmpty()) {

for(...: qAsConst(...))

> fakeserver.h:37
> +    explicit FakeServer(QObject *parent = nullptr);
> +    ~FakeServer() Q_DECL_OVERRIDE;
> +

Q_decl_override here ?
if necessary replace it by override

> fakeserver.h:40
> +    void startAndWait();
> +    void run() Q_DECL_OVERRIDE;
> +

override

REPOSITORY
  R84 PIM: KMail Transport

REVISION DETAIL
  https://phabricator.kde.org/D6879

To: dvratil, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170724/519d7d42/attachment.html>