D6739: [akregator part] Protect part from auto delete

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dvratil wrote in mainwindow.cpp:118
> Now that the Frame is wrapped in QPointer, it should be OK leave the part to auto-delete itself. Otherwise we would be memory-leaking the part?

I can't understaind why Qt deletes part' widget (this is only in session restored mode), someone else set a centralWidget ?
Backtrace -> https://paste.kde.org/pzbqweaj3

> dvratil wrote in mainwindow.cpp:139
> Why remove this check? I would assume it's there to prevent re-loading the part if it is already loaded.

It has a check inside loadPart.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D6739

To: anthonyfieroni, mlaurent, #kde_pim, dfaure, dvratil
Cc: dvratil, alexeymin, genaxxx, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170723/3d2edac3/attachment.html>