D6739: [akregator part] Protect part from auto delete

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mainwindow.cpp:118
>      setCentralWidget(m_part->widget());
> +    m_part->setAutoDeletePart(false);
>  

Now that the Frame is wrapped in QPointer, it should be OK leave the part to auto-delete itself. Otherwise we would be memory-leaking the part?

> mainwindow.cpp:139
>  {
> -    if (!m_part) {
> -        if (!loadPart()) {

Why remove this check? I would assume it's there to prevent re-loading the part if it is already loaded.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D6739

To: anthonyfieroni, mlaurent, #kde_pim, dfaure, dvratil
Cc: dvratil, alexeymin, genaxxx, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170723/de54479e/attachment.html>