D6977: servertest: add NNTP support
Laurent Montel
noreply at phabricator.kde.org
Sun Jul 30 07:41:26 BST 2017
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> servertest.cpp:422
> + } else if (testProtocol == NNTP_PROTOCOL) {
> + if (handleNntpConversation(normalSocket, encryptionMode, &normalStage, text,
> + &shouldStartTLS)) {
Why use normalStage as reference ?
We don't use it as reference in other place as it's already defined
> it avoids to add an extra test
================================
REPOSITORY
R84 PIM: KMail Transport
REVISION DETAIL
https://phabricator.kde.org/D6977
To: pino, #kde_pim, mlaurent
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170730/6a74d4b0/attachment.html>
More information about the kde-pim
mailing list