Review Request 129668: Add Armistice day of WWI to holidays for Serbia

[Luigi Toscano]

> On Gen. 12, 2017, 10:15 p.m., Allen Winter wrote:
> > ping. this has a shipit.
> 
> Luigi Toscano wrote:
>     wait, -1, if the date become public date only from a certain date, you can specify it. See how I did it for the Italian "Festa della Repubblica:
>     
>     https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?h=Applications/16.12#n27
>     https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?h=Applications/16.12#n80
> 
> Chusslove Illich wrote:
>     I'm not sure if it makes sense to start tracking introduction years. Some of the other listed holidays are not very old either. This is Balkans we are speaking of, after all.

On the other side, if you don't start from some point you are never going to start.

Think about the use case: "I'm looking to the calendar of last year to check $something" and without boundaries you can't be sure about the public holidays.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129668/#review101973
-----------------------------------------------------------


On Dic. 18, 2016, 1:02 p.m., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129668/
> -----------------------------------------------------------
> 
> (Updated Dic. 18, 2016, 1:02 p.m.)
> 
> 
> Review request for KDEPIM and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> -------
> 
> Armistice day of World War I is now a public holiday in Serbia. Added to holiday definitions for all four Serbian variants.
> 
> 
> Diffs
> -----
> 
>   holidays/plan2/holiday_rs_sr 6223111 
>   holidays/plan2/holiday_rs_sr at ijekavian 620dc97 
>   holidays/plan2/holiday_rs_sr at ijekavianlatin f5c9d61 
>   holidays/plan2/holiday_rs_sr at latin e3dd519 
> 
> Diff: https://git.reviewboard.kde.org/r/129668/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170114/18fcc4b3/attachment.html>