Review Request 129788: [akonadi] Rename exception.h to exceptionbase.h and revert workaround

Daniel Vrátil dvratil at kde.org
Sat Jan 7 22:26:52 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129788/#review101853
-----------------------------------------------------------


Ship it!




If there are no other adjustments needed (in other repositories) then ship it (into master only).

- Daniel Vrátil


On Jan. 7, 2017, 8:21 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129788/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 8:21 p.m.)
> 
> 
> Review request for Akonadi and Daniel Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> Do not hardcode absolute patchs to GCC headers.
> 
> This reverts commit 59b9d6b79425c9ec1e5df059a2593580048c4adf.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindStdlibInclude.cmake 820040da448bc1509ea3b7466d6695abd9c57383 
>   src/core/CMakeLists.txt 72589cd180fe51f207c70f8ffbb19ee3b7755f80 
>   src/core/exception.h 5caa41bbbbcdc1282bd8914c8dfb2053fc52079a 
>   src/core/exception.cpp f229c1a2ed76332ce16b27eb5b868cdd0eb078f9 
>   src/core/item.h de71cada122bee94f67cac9a69d29cf6591268c4 
>   src/core/itempayloadinternals_p.h 0a4de3cd76741dc908f8e46e273b70536da576b7 
>   src/core/protocolhelper.cpp f740e9dbdfd3ae032a58bb46561a872ef60e2b3e 
> 
> Diff: https://git.reviewboard.kde.org/r/129788/diff/
> 
> 
> Testing
> -------
> 
> Rebuilt all of kdepim successfully.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170107/04357afd/attachment.html>


More information about the kde-pim mailing list