Review Request 129667: Fix calendar system checks for pascha

[Chusslove Illich]

> On Дец. 26, 2016, 5:11 по п., Daniel Vrátil wrote:
> > Indeed looks like a typo during porting. Ship it!
> 
> Luigi Toscano wrote:
>     as bugfix (porting regression), can this go to Applications/16.12 instead of master (and then merged as usual)?

It would be very nice to have it in Applications/16.12 as well. What is the proper commit/merge sequence for that. As in, I commit to 16.12 and then someone else merges, or I merge, or?


- Chusslove


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129667/#review101578
-----------------------------------------------------------


On Дец. 18, 2016, 1:07 по п., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129667/
> -----------------------------------------------------------
> 
> (Updated Дец. 18, 2016, 1:07 по п.)
> 
> 
> Review request for KDEPIM and John Layt.
> 
> 
> Repository: kholidays
> 
> 
> Description
> -------
> 
> Date of pascha is currently computed wrongly. Commit b47ddff6 (switch from KCalendarSystem to QCalendarSystem) reversed all calendar system checks from equality to inequality in HolidayParserDriverPlan::pascha(), it seems to me by error (e.g. the first check is always true after the change). After reverting to equality checks, pascha date computation is correct.
> 
> 
> Diffs
> -----
> 
>   src/parsers/plan2/holidayparserdriverplan.cpp 940dfe5 
> 
> Diff: https://git.reviewboard.kde.org/r/129667/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chusslove Illich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170114/c8083040/attachment.html>