Review Request 129836: Use custom font im KMail message list

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129836/#review102060
-----------------------------------------------------------



Looks good to me. The optimization that removed the font customization was to prevent using different fonts within single delegate. This change just applies different font to the entire delegate, so it should be OK. Just address the improvement in Laurent's comment please.


In the long-term we should however consider removing or reducing the custom font settings in KMail - this entire configuration page is from the early days when there was no system-wide font settings in KDE (or so I'm told, that was looong before me :-)), which is not the case anymore and we should just follow the system defaults everywhere and only allow for color customization. But that's for another discussion....

- Daniel Vrátil


On Jan. 15, 2017, 12:24 p.m., Gerd Fleischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129836/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 12:24 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 362803
>     https://bugs.kde.org/show_bug.cgi?id=362803
> 
> 
> Repository: messagelib
> 
> 
> Description
> -------
> 
> Use custom font in KMail Messagelist if checked,
> currently the systemfont is always used.
> 
> This is related to BUG 362803
> 
> 
> Diffs
> -----
> 
>   messagelist/src/core/themedelegate.cpp 9b71bfc 
> 
> Diff: https://git.reviewboard.kde.org/r/129836/diff/
> 
> 
> Testing
> -------
> 
> Switching custom font and size in KMail message list works for me now.
> 
> 
> Thanks,
> 
> Gerd Fleischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170116/37cd055e/attachment.html>