ItemFetchJob never finishes

[David Faure]

In both 16.12 and master, I have regularly the problem that KMail gets stuck
in a job, and then it won't do any other job (e.g. deleting an email, fetching new mails, etc.)

The screenshot attached shows that it's an ItemFetchJob for ID 458937 which never finishes.

Grepping the logs for that ID shows the following:

2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::requestItemDelivery: posting retrieval request for items (458937)  there are  1  queues and  0  items in mine
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalJob::start: processing retrieval request for item (458937)  parts: ("ENVELOPE")  of resource: "akonadi_imap_resource_2"
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::requestItemDelivery: posting retrieval request for items (458937)  there are  1  queues and  0  items in mine
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::requestItemDelivery: posting retrieval request for items (458937)  there are  1  queues and  1  items in mine
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::requestItemDelivery: posting retrieval request for items (458937)  there are  1  queues and  2  items in mine
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::retrievalJobFinished: someone else requested item (458937) as well, marking as processed
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::retrievalJobFinished: someone else requested item (458937) as well, marking as processed
2017-01-17T23:38:50 Akonadi(8254)/org.kde.pim.akonadiserver Akonadi::Server::ItemRetrievalManager::retrievalJobFinished: someone else requested item (458937) as well, marking as processed
2017-01-17T23:38:50 akonadi_archivemail_agent(2956)/org.kde.pim.akonadicore Akonadi::EntityTreeModelPrivate::monitoredItemChanged: Got a stale notification for an item which was already removed. 458937 ""

It looks like this code in retrievalJobFinished is the problem, I usually don't get that "someone else requested item ... as well" debug output, and I do remember seeing it the last time this same bug happened.

Dan, can you double-check that piece of code in ItemRetrievalManager? Does it somehow fail to terminate the client job?

(Is this code path unittested and does the test pass? ;) )

Thanks!

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot_20170118_001027.png
Type: image/png
Size: 614321 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170118/fe798158/attachment.png>