Review Request 129726: Use "${CMAKE_DL_LIBS}" instead of "dl".

[Christian Mollekopf]

> On Jan. 23, 2017, 3:57 p.m., Christian Mollekopf wrote:
> > Thanks for the patch!
> > 
> > Sorry for the slow response, we're really only using phabricator.kde.org.
> > 
> > I applied your patch directly, so you don't have to (It's still in a branch, but will be merged eventually).
> 
> Albert Astals Cid wrote:
>     Should i mark this as closed then?
> 
> Tobias Berner wrote:
>     As the repo did not include a .arconfig I assumed it wasn't yet moved to phab :) -- sorry.
> 
> Christian Mollekopf wrote:
>     Both good points, I'll fix that as well (arcconfig and closing) =)

Actually, I can't fix the closing it seems. Please close the report if you can, thanks.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129726/#review102214
-----------------------------------------------------------


On Dec. 30, 2016, 11:18 a.m., Tobias Berner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129726/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2016, 11:18 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Repository: sink
> 
> 
> Description
> -------
> 
> FreeBSD does not need -ldl.
> 
> So `target_link_libraries(${PROJECT_NAME} sink KF5::Async dl)` does not work.
> 
> 
> Diffs
> -----
> 
>   synchronizer/CMakeLists.txt b2bde55 
> 
> Diff: https://git.reviewboard.kde.org/r/129726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170123/dc645668/attachment.html>