Review Request 129667: Fix calendar system checks for pascha

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129667/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 8:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and John Layt.


Changes
-------

Submitted with commit 637862700fe0d8bd2a8b6e351d5a7fc4a628b969 by Chusslove Illich (?????? ????) to branch master.


Repository: kholidays


Description
-------

Date of pascha is currently computed wrongly. Commit b47ddff6 (switch from KCalendarSystem to QCalendarSystem) reversed all calendar system checks from equality to inequality in HolidayParserDriverPlan::pascha(), it seems to me by error (e.g. the first check is always true after the change). After reverting to equality checks, pascha date computation is correct.


Diffs
-----

  src/parsers/plan2/holidayparserdriverplan.cpp 940dfe5 

Diff: https://git.reviewboard.kde.org/r/129667/diff/


Testing
-------


Thanks,

Chusslove Illich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170117/0f50ec02/attachment.html>