Review Request 129958: Make Qt l10 tools happier

Albert Astals Cid aacid at kde.org
Tue Feb 21 18:48:12 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129958/
-----------------------------------------------------------

(Updated Feb. 21, 2017, 6:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries, Daniel Vrátil and Elvis Angelaccio.


Changes
-------

Submitted with commit 4a333eb1060f6224fe409d7d219a0ed488691684 by Albert Astals Cid to branch master.


Repository: libkgapi


Description
-------

Without this patch we get
/home/kdeunstable/libkgapi/src/core/ui/authwidget_p.h:50: Ignoring definition of undeclared qualified class
/home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:72: Qualifying with unknown namespace/class ::AuthWidget
/home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:169: Qualifying with unknown namespace/class ::AuthWidget
/home/kdeunstable/libkgapi/src/core/ui/authwidget_p.h:50: Ignoring definition of undeclared qualified class
/home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:72: Qualifying with unknown namespace/class ::AuthWidget
/home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:169: Qualifying with unknown namespace/class ::AuthWidget


Diffs
-----

  src/core/ui/authwidget.h 31fefaa 
  src/core/ui/authwidget.cpp c95eec3 
  src/core/ui/authwidget_p.h 2cda13f 
  src/core/ui/authwidget_p.cpp 97b76f2 

Diff: https://git.reviewboard.kde.org/r/129958/diff/


Testing
-------

Warnings are gone


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170221/c165ce81/attachment.html>


More information about the kde-pim mailing list