[Differential] [Request, 311 lines] D4791: RFC: Split mail folder view into one view per account using tabs

[Daniel Vrátil]

dvratil created this revision.
dvratil added a project: KDE PIM.

REVISION SUMMARY
  This is an experiment that I hacked together to see how it would work and feel to have folders separated to per-account tabs. The code still needs work, but I'd like to know your opinions on this first before I sink more time into the feature.
  
  The idea is that instead of having a single tree of all folders, you have per-account tabs on the side and each tab only shows folders from given account.
  
  F2610200: kmail-new-accounts-1.png <https://phabricator.kde.org/F2610200>
  
  I think this could make the folder view a bit easier to use if you have lots and lots of folders and multiple accounts (like we all do :-)). The patch is written in a way that the feature can very easily be turned off, because this separation does not make much sense if you only have Local Folders plus maybe one IMAP account or if all your folders fit onto your screen.
  
  I have some more ideas that are not implemented yet, I would like to know your opinions on them too
  
  - better indication of unread email count (blue bold number next to the account name instead of the current plain text)
  - per-account colors - each account would have its own color and the tab and the view background would have the same color and the color would be used everywhere else in KMail when there's a Folder selection combobox or something like that to make it easy to quickly identify which account the folder belongs to. This is inspired by recent KDevelop feature where each project has a different color and then each file tab has the color based on which project the file belongs to to make it easier to navigate between files: F2610234: kdev-colors.png <https://phabricator.kde.org/F2610234>
  - Right-clicking the tab would show a context menu with following actions:
    - Synchronize all folders
    - Account configuration (opens respective resource configuration dialog)
    - Remove account (??)
    - Customize (set custom icon, color etc.)
  - Drag&drop to reorder the accounts (replacing Settings -> Configure KMail -> Accounts -> Customize account order)
  - possibility to set a shortcut for each tab to quickly toggle between them
  - your idea comes here :-)
  
  If you want to test the patch, you also need to apply the following patch to kmail.git to enable the feature:
  
    diff --git a/src/kmmainwidget.cpp b/src/kmmainwidget.cpp
    index c9b06d1..f4446f6 100644
    --- a/src/kmmainwidget.cpp
    +++ b/src/kmmainwidget.cpp
    @@ -987,4 +987,5 @@ void KMMainWidget::createWidgets()
         opt |= FolderTreeWidget::UseLineEditForFiltering;
         opt |= FolderTreeWidget::ShowCollectionStatisticAnimation;
         opt |= FolderTreeWidget::DontKeyFilter;
    +    opt |= FolderTreeWidget::UseAccountTabs;
         mFolderTreeWidget = new FolderTreeWidget(this, mGUIClient, opt);

REPOSITORY
  R92 PIM: Common Mail Support

REVISION DETAIL
  https://phabricator.kde.org/D4791

AFFECTED FILES
  src/CMakeLists.txt
  src/folder/accounttabbar.cpp
  src/folder/accounttabbar_p.h
  src/folder/foldertreewidget.cpp
  src/folder/foldertreewidget.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mlaurent, bjoernbalazs
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170225/7b46c3b9/attachment.html>