Review Request 129958: Make Qt l10 tools happier

Daniel Vrátil dvratil at kde.org
Tue Feb 21 13:13:41 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129958/#review102564
-----------------------------------------------------------


Ship it!




- Daniel Vrátil


On Feb. 19, 2017, 1:10 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129958/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2017, 1:10 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil and Elvis Angelaccio.
> 
> 
> Repository: libkgapi
> 
> 
> Description
> -------
> 
> Without this patch we get
> /home/kdeunstable/libkgapi/src/core/ui/authwidget_p.h:50: Ignoring definition of undeclared qualified class
> /home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:72: Qualifying with unknown namespace/class ::AuthWidget
> /home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:169: Qualifying with unknown namespace/class ::AuthWidget
> /home/kdeunstable/libkgapi/src/core/ui/authwidget_p.h:50: Ignoring definition of undeclared qualified class
> /home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:72: Qualifying with unknown namespace/class ::AuthWidget
> /home/kdeunstable/libkgapi/src/core/ui/authwidget_p.cpp:169: Qualifying with unknown namespace/class ::AuthWidget
> 
> 
> Diffs
> -----
> 
>   src/core/ui/authwidget.h 31fefaa 
>   src/core/ui/authwidget.cpp c95eec3 
>   src/core/ui/authwidget_p.h 2cda13f 
>   src/core/ui/authwidget_p.cpp 97b76f2 
> 
> Diff: https://git.reviewboard.kde.org/r/129958/diff/
> 
> 
> Testing
> -------
> 
> Warnings are gone
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170221/02574b1c/attachment.html>


More information about the kde-pim mailing list