[Differential] [Commented On] D4618: Fix ItemRetriever in case of concurrent requests for the same item(s)

David Faure noreply at phabricator.kde.org
Thu Feb 16 10:09:29 GMT 2017


dfaure added inline comments.

INLINE COMMENTS

> dvratil wrote in itemretrievertest.cpp:324
> Should you maybe `thread.wait()` here to make sure it finishes before you try to extract the results below?

No, I call run() directly, not start(), here.

I admit it's a bit confusing, but at step 0 I wanted to keep the non-multithreaded testcase, to make debugging easier.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D4618

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170216/727d7815/attachment.html>


More information about the kde-pim mailing list