[Differential] [Request, 48 lines] D4708: Add export macro for private classes with unittest.

[David Faure]

dfaure created this revision.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  Otherwise I get
  
    undefined reference to `vtable for MailCommon::KMFilterAccountList'
  
  when linking filteractionmissingaccountdialogtest.
  Must be a consequence of the recent changes in cmake git (autogen feature).
  
  There are a ton more files that are included directly rather than the
  classes being exported though (which can make refactorings harder, e.g.
  when new cpp files are added as dependencies of the existing ones,
  suddenly it becomes complex to know what to compile in).
  
  Should we go fully in the direction of exporting the stuff we need
  when building tests, and compiling these cpp files only once, as a result?

TEST PLAN
  Now it builds with clang

REPOSITORY
  R92 PIM: Common Mail Support

BRANCH
  Applications/16.12

REVISION DETAIL
  https://phabricator.kde.org/D4708

AFFECTED FILES
  src/CMakeLists.txt
  src/filter/autotests/CMakeLists.txt
  src/filter/kmfilteraccountlist.h
  src/mailcommon_private_export.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, mlaurent, ervin, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170221/f181335f/attachment.html>