D9417: EntityOrderProxyModel: support adding a favorite at a specific position

David Faure noreply at phabricator.kde.org
Tue Dec 19 22:24:08 GMT 2017


dfaure created this revision.
dfaure added reviewers: dvratil, mlaurent.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  If EntityTreeModel::modelIndexForCollection() doesn't find the
  collection we're dropping, then insert it first (via the base class
  dropMimeData) and then look for it again, to handle it as a move.
  
  I hope this doesn't affect other EOPM users than the favorites model;
  but when reordering a full ETM surely the dropped folder is somewhere in the
  ETM.

TEST PLAN
  When using the ListView mode for the favorites, this allows to
  directly drop a new folder (from the folder tree) to a specific position,
  as shown by the "between items" drop indicator.

REPOSITORY
  R165 Akonadi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9417

AFFECTED FILES
  src/core/models/entityorderproxymodel.cpp
  src/core/models/entityorderproxymodel.h

To: dfaure, dvratil, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171219/31747afb/attachment.html>


More information about the kde-pim mailing list