D9231: KOrganizer Summary Plugin: restore tooltips for appointments

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:55
>  if (BUILD_TESTING)
> -   add_subdirectory(autotests)
> +#FIXME: port summaryeventtest to Akonadi
> +#   add_subdirectory(autotests)

Add a CMake warning otherwise we never readd this one if we don't know it.

> summaryeventinfo.cpp:94
>  SummaryEventInfo::List SummaryEventInfo::eventsForRange(const QDate &start, const QDate &end,
> -        KCalCore::Calendar *calendar)
> +        Akonadi::ETMCalendar::Ptr calendar)
>  {

const'ref

> summaryeventinfo.cpp:240
>  
> -         QString tipText( KCalUtils::IncidenceFormatter::toolTipStr(
> -                           KCalUtils::IncidenceFormatter::resourceString(
> -                             calendar, ev ), ev, start, true, spec ) );
> -        if ( !tipText.isEmpty() ) {
> -          summaryEvent->summaryTooltip = tipText;
> -        }*/
> +        QString rs;
> +        Akonadi::Item item = calendar->item(ev);

rs == displayName no ? so better to rename as displaynName no ?

> summaryeventinfo.cpp:243
> +        if (item.isValid()) {
> +            Akonadi::Collection col = item.parentCollection();
> +            if (col.isValid()) {

const Akonadi::Collection

> summaryeventinfo.cpp:289
>  SummaryEventInfo::List SummaryEventInfo::eventsForDate(const QDate &date,
> -        KCalCore::Calendar *calendar)
> +        Akonadi::ETMCalendar::Ptr calendar)
>  {

const'ref here

> summaryeventinfo.h:42
>      static List eventsForDate(const QDate &date,
> -                              KCalCore::Calendar *calendar);
> +                              Akonadi::ETMCalendar::Ptr calendar);
>      static List eventsForRange(const QDate &start, const QDate &end, // range is inclusive

same const'ref and after too

REPOSITORY
  R210 KOrganizer

REVISION DETAIL
  https://phabricator.kde.org/D9231

To: winterz, dvratil, mlaurent
Cc: mlaurent, #kde_pim, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171207/1f3487d0/attachment.html>