D7549: Remove unused EditorItemManager methods

Denis Kurz noreply at phabricator.kde.org
Fri Aug 25 22:57:11 BST 2017


dkurz created this revision.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  The methods (set)fetchScope were never used. They also violate
  encapsulation: setting an arbitrary fetch scopes might lead to some
  features not being fetched that are required by IncidenceDialog to work
  correctly, like item tags including tag names.

TEST PLAN
  It compiles; projects depending on IncidenceEditor compile, too.
  The methods are neither signals nor slots, so they are not used
  in a string-based connect. In summary: they are actually not used 
  anywhere

REPOSITORY
  R78 PIM: Incidence Editor

BRANCH
  hotfix-remove-unused-incidenceeditor-fetchscope-methods

REVISION DETAIL
  https://phabricator.kde.org/D7549

AFFECTED FILES
  src/editoritemmanager.cpp
  src/editoritemmanager.h

To: dkurz, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170825/24ff5b8e/attachment.html>


More information about the kde-pim mailing list