D7500: Event view can use the CollectionColorAttribute color

Denis Kurz noreply at phabricator.kde.org
Thu Aug 24 07:52:25 BST 2017


dkurz added inline comments.

INLINE COMMENTS

> helper.cpp:50
> +            // It's the same color: we don't want to save it
> +            return;
> +        }

Should the color preference for this calendar be reset here? If preference == red, collection color == blue, and then the user decides to set preference = blue, this wouldn't have an effect and still display red, would it?

> helper.cpp:92
> +        }
> +    }
> +    return color;

Lines 84-92 are the same as lines 65-73 (except for "coll" vs. "item.parentCollection()"), so it should probably be extracted to a method.

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D7500

To: ochurlaud, dvratil
Cc: dkurz, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170824/d31d7168/attachment.html>


More information about the kde-pim mailing list