D7056: Fix bug #378513: akregator crash on session restore

[Matthijs Tijink]

mtijink created this revision.
mtijink added a project: KDE PIM.

REVISION SUMMARY
  I think this fixes bug #378513. The bug occurred (during session restore) when the code tries to cast to a `WebFrameEngine`, but since the main frame has already been deleted, this fails.
  
  Using this code, the `MainWidget` removes the main frame from the frame manager before it's deleted. I'm not sure this fully fixes the original problem, but I do not have crashes anymore with this diff. Note: I only tested it on the Applications/17.4 branch, since master required compiling lots of packages, so you may want to test it on master first.

TEST PLAN
  No crashes anymore for me. I could replicate the original bug by trying to restore from a session.

REPOSITORY
  R201 Akregator

BRANCH
  fix_bug_378513

REVISION DETAIL
  https://phabricator.kde.org/D7056

AFFECTED FILES
  src/frame/framemanager.cpp
  src/frame/framemanager.h
  src/mainwidget.cpp

To: mtijink, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170801/cfa14c6c/attachment.html>