D7206: Fix specifying the charset when exporting as HMTL

Wolfgang Bauer noreply at phabricator.kde.org
Tue Aug 8 17:40:37 BST 2017


wbauer created this revision.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  The QString::replace() had no effect because the stream actually contains <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">, not just <!DOCTYPE html>.
  
  Also, the <meta> tag should be inside the <head> section.
  
  BUG: 374260

TEST PLAN
  Select a mail with german umlauts or other special characters, and choose "Print Preview".
  The characters are displayed correctly now in the Webbrowser.
  
  The temporary file contains now:
  <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"><html><head><meta charset="UTF-8"><title></title><style>...

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D7206

AFFECTED FILES
  webengineviewer/src/webengineexporthtmlpagejob.cpp

To: wbauer, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170808/47d32581/attachment.html>


More information about the kde-pim mailing list