D7591: Fix use-after-free

[Denis Kurz]

dkurz created this revision.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  We now detect if IncidenceAttachment is deleted while the
  AttachmentEditDialog is shown. There were three potential crashes
  (deletion of item; access to mAttachmentView; call checkDirtyStatus);
  the first of them actually was met in the wild in Bug 356053. Fixing
  only the deletion of item led to the other two.
  
  BUG: 356053
  FIXED-IN: 5.6.1

TEST PLAN
  Compiled; repeated the steps described in Bug 356053. The crash
  happens without the patch; doesn't happen with the patch.

REPOSITORY
  R78 PIM: Incidence Editor

BRANCH
  hotfix-attachmentdialog-crash-on-exit

REVISION DETAIL
  https://phabricator.kde.org/D7591

AFFECTED FILES
  src/incidenceattachment.cpp

To: dkurz, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170828/05de38be/attachment.html>