D7285: pim-sieve-editor: sieveeditormainwindow: use QPointer to protect crash of ImportImapSettingWizard

Laurent Montel noreply at phabricator.kde.org
Mon Aug 14 07:05:39 BST 2017


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> sieveeditormainwindow.cpp:266
>  {
> -    ImportImapSettingWizard w(this);
> -    if (w.exec()) {
> +    QPointer<ImportImapSettingWizard> w = new ImportImapSettingWizard(this);
> +    if (w->exec()) {

We don't access to data from ImportImapSettingWizard so which crash it can fix ?

REPOSITORY
  R213 PIM Sieve Editor

REVISION DETAIL
  https://phabricator.kde.org/D7285

To: winterz, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170814/bb009334/attachment.html>


More information about the kde-pim mailing list