D7114: Remove useless check
Daniel Vrátil
noreply at phabricator.kde.org
Fri Aug 4 09:44:34 BST 2017
dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> modify.cpp:200
>
> - if (changed || cmd.modifiedParts() & Protocol::ModifyCollectionCommand::MimeTypes) {
> - if (changed) {
> - changes.append(AKONADI_PARAM_PERSISTENTSEARCH);
> - }
> + if (changed) {
> + changes.append(AKONADI_PARAM_PERSISTENTSEARCH);
I think the outer condition should remain and the inner one should be removed - looking into git history, that's how it was intended to be.
REPOSITORY
R165 Akonadi
REVISION DETAIL
https://phabricator.kde.org/D7114
To: dkurz, #kde_pim, dvratil
Cc: dvratil, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170804/646c4c1f/attachment.html>
More information about the kde-pim
mailing list