Review Request 130074: Don't block users work with a message box on download error

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130074/#review103019
-----------------------------------------------------------


Fix it, then Ship it!




Looks good to me.


resources/pop3/pop3resource.cpp (line 953)
<https://git.reviewboard.kde.org/r/130074/#comment68537>

    The 4th argument should be QPixmap()


- Daniel Vrátil


On April 9, 2017, 4:03 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130074/
> -----------------------------------------------------------
> 
> (Updated April 9, 2017, 4:03 p.m.)
> 
> 
> Review request for KDEPIM, Albert Astals Cid and Daniel Vrátil.
> 
> 
> Bugs: 377553
>     http://bugs.kde.org/show_bug.cgi?id=377553
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Instead of blocking users work with a MessageBox dialog, just display the error via the KDE Notification framework.
> Additional benefit of using KNotification: the user can configure how this is handled.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 33b55d5db 
>   resources/pop3/CMakeLists.txt 508e810c6 
>   resources/pop3/akonadi_pop3_resource.notifyrc PRE-CREATION 
>   resources/pop3/pop3resource.cpp ef4e02c3b 
> 
> Diff: https://git.reviewboard.kde.org/r/130074/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170410/cc9ea81e/attachment.html>