Batch-reset RID -> empty RID with maildir

[Martin Koller]

Hi,

as already mentioned last week, the change 66b87061f5 (see T3904 in Phab)
leads to an item sometimes ending up no longer having its RID (I'm only testing maildir).

The commit comment says
"This change reset RID of all moves Items and only emits the RID
    as part of the change notification. The Monitor then retrieves the
    Item without the RID and restores the RID from the Notification,
    so this is absolutely transparent to Resources."

can you explain these steps a bit in more detail, please ?
What happens (or should happen) here in which order ?

I found situations like this:
- maildir and mailfilter get notified about a new item
- maildir sends a message to set the RID
- mailfilter sends the move command
- in the DB we now have no RID

You can reproduce this with the attached test-resource, which creates 20 new items.
When you have some filters defined (I have ~20 before the matching one),
where one then moves these new mails into some
other folder, I often end up having 2-3 items without RID in the DB

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\                        - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestResource.cxx
Type: text/x-c++src
Size: 4943 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170429/41db515f/attachment.cxx>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CMakeLists.txt
Type: text/x-cmake
Size: 1021 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170429/41db515f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestResource.desktop
Type: application/x-desktop
Size: 240 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170429/41db515f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestResource.hxx
Type: text/x-c++hdr
Size: 820 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170429/41db515f/attachment.hxx>