Review Request 130074: Don't block users work with a message box on download error

Martin Koller kollix at aon.at
Mon Apr 10 20:38:52 BST 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130074/
-----------------------------------------------------------

(Updated April 10, 2017, 7:38 p.m.)


Review request for KDEPIM, Albert Astals Cid and Daniel Vrátil.


Bugs: 377553
    http://bugs.kde.org/show_bug.cgi?id=377553


Repository: kdepim-runtime


Description
-------

Instead of blocking users work with a MessageBox dialog, just display the error via the KDE Notification framework.
Additional benefit of using KNotification: the user can configure how this is handled.


Diffs (updated)
-----

  CMakeLists.txt 33b55d5db 
  resources/pop3/CMakeLists.txt 508e810c6 
  resources/pop3/akonadi_pop3_resource.notifyrc PRE-CREATION 
  resources/pop3/pop3resource.cpp ef4e02c3b 

Diff: https://git.reviewboard.kde.org/r/130074/diff/


Testing
-------

yes


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170410/fff7cc26/attachment.html>


More information about the kde-pim mailing list