Review Request 130051: Allow the user to silence some sync warnings

[Albert Astals Cid]

> On March 27, 2017, 7:21 a.m., Martin Koller wrote:
> > Personally this at least solves my issue. Thanks for this.
> > Still I wonder why this is only done in the POP resource and not (or different) in others.
> > This is inconsistent.
> > 
> > Also I think it should not be up to the resource to decide HOW an error or warning is displayed.
> > AFAIK therefore the Akonadi::AgentBase signals like 
> > void 	warning (const QString &message)
> > void 	error (const QString &message)
> > are available.
> 
> Albert Astals Cid wrote:
>     Those messages end up in some log that noone will see.
>     
>     As i already said, if yahoo fails to log me in with an error that says "You need to log in the webpage first because we don't like you" (google gives similar errors) we need to show them to the user.
> 
> Albert Astals Cid wrote:
>     s/Those messages/Those methods
> 
> Laurent Montel wrote:
>     How we can reactivate after that theses messagebox ?
>     Albert is right it's important to see theses warning/error otherwise we don't know why there is a problem and it's difficult to debug it.
> 
> Albert Astals Cid wrote:
>     > How we can reactivate after that theses messagebox ?
>     
>     You have to edit the config file like in all "Don't show me again".
>     
>     Note the "Don't show me again" is per error type and server, so if you press "Don't show me again" in a "Could not connect to host" error, it will still show an error in a "failed login because the server is weird" case, so i think it's ok.
>     
>     Eventually it would be nice to have a generic solution to be able to reenable the "Don't show me again" messages, but i think it's out of scope for this.
> 
> Daniel Vrátil wrote:
>     We still need to clear the flag after the connection is succesfully established, otherwise the user won't ever again be warned about it, which is not desirable, so then you should call `KMessageBox::enableMessage()`, probably in `loginJobResult()` before calling `advanceStep()`.

Well the user clearly said he didn't want to be notified about it, given the "ignore me" is per server and per error i don't see why we need to reenable it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130051/#review102952
-----------------------------------------------------------


On March 26, 2017, 11:20 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130051/
> -----------------------------------------------------------
> 
> (Updated March 26, 2017, 11:20 p.m.)
> 
> 
> Review request for KDEPIM and Martin Koller.
> 
> 
> Bugs: 377553
>     http://bugs.kde.org/show_bug.cgi?id=377553
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> One user has complained that an error dialog pops up when the server can't be contacted (e.g. behind a vpn or something)
> 
> First i thought of not showing the error for ERR_UNKNOWN_HOST errors, but then i thought it would make sense to be notified at least once if you wrote the address wrong, so i went for the "don't show me again" route.
> 
> 
> Diffs
> -----
> 
>   resources/pop3/pop3resource.h 544b25be4 
>   resources/pop3/pop3resource.cpp ef4e02c3b 
> 
> Diff: https://git.reviewboard.kde.org/r/130051/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170403/6fa1ddca/attachment.html>