[Differential] [Request, 4 lines] D2717: ErrorOverlay: fix dialogs being disabled by the mainwindow
dfaure (David Faure)
noreply at phabricator.kde.org
Fri Sep 9 00:36:59 BST 2016
dfaure created this revision.
dfaure added reviewers: vkrause, dvratil.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.
REVISION SUMMARY
Testcase: open "jump to folder", cancel, restart akonadi,
reopen the dialog, it was disabled.
This happened because disabling the window actually disables
the child dialog too, so the saved state for the dialog was
"disabled". The fix is to save the "explicitly disabled" state
rather than isDisabled(). Thanks to Volker for helping me figure
this out.
REPOSITORY
rAKONADI Akonadi
BRANCH
Applications/16.08
REVISION DETAIL
https://phabricator.kde.org/D2717
AFFECTED FILES
src/widgets/erroroverlay.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, vkrause, dvratil
Cc: kde-pim, #kde_pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160908/2ed2d00d/attachment.html>
More information about the kde-pim
mailing list